Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: refactor linter#parseBooleanConfig to improve readability #11074

Merged
merged 4 commits into from Nov 11, 2018

Conversation

aladdin-add
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)
a very small refactor to improve readability.

Is there anything you'd like reviewers to focus on?
no.

@aladdin-add aladdin-add added core Relates to ESLint's core APIs and features accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing labels Nov 10, 2018
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to look up String.prototype.split to remember how it handled this case (separator not present), so I think a comment with 1-2 examples couldn't hurt. LGTM though, thanks for contributing!

lib/linter.js Outdated Show resolved Hide resolved
@aladdin-add aladdin-add merged commit e18c827 into eslint:master Nov 11, 2018
@aladdin-add aladdin-add deleted the chore/refactor-linter branch November 11, 2018 15:42
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators May 11, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label May 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing core Relates to ESLint's core APIs and features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants