Docs: no-console#When-Not-To-Use provides incorrect rule snippet #11093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current selector results in a warning for `console.log()` instead of `console.foobar()`. The 'unexpectd property' should be selected with `!=` Also, turning off "no-console" is still required to achieve "only receiving errors for console calls with unexpected property" Add missing "no-console: off" for `When Not To Use It` snippet
eslint-deprecated
bot
added
the
triage
platinumazure
approved these changes
Nov 17, 2018
platinumazure
added
rule
|
cool! but do i need to do anything like trigger a rebuild? |
|
@choznerol Nope, we'll handle it 😄 |
|
@choznerol Merged, thanks for contributing! (And apologies for the delay in getting this in.) |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
What changes did you make? (Give an overview)
The snippet provided in no-console#When Not To Use It aims to achieve "only receiving errors for console calls" but the selector results in a warning for
console.log()instead ofconsole.foobar().To fix it, the 'unexpected property' should be selected with
!=instead of=. Also, turning off "no-console" is still required to achieve "only receiving errors for console calls with unexpected property"After change:
console.log()is okconsole.logs()is warnedIs there anything you'd like reviewers to focus on?