Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch incorrect example with correct one #11107

Merged
merged 1 commit into from Nov 21, 2018
Merged

switch incorrect example with correct one #11107

merged 1 commit into from Nov 21, 2018

Conversation

romainlq
Copy link

@romainlq romainlq commented Nov 21, 2018

It looks like we always show the incorrect example first, so the fact that in this example we want to show the correct code first might be on purpose, but it does not look like it is

What is the purpose of this pull request? (put an "X" next to item)

  • Documentation update

What changes did you make? (Give an overview)
I switched the correct code with the incorrect one, not the code itselft, just the text since we always show the incorrect code first

Is there anything you'd like reviewers to focus on?

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Nov 21, 2018
It looks like we always show the incorrect example first, so the fact that in this example we want to show the correct code first might be on purpose, but it does not look like it is
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for contributing!

@not-an-aardvark not-an-aardvark merged commit cf296bd into eslint:master Nov 21, 2018
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators May 21, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label May 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion triage An ESLint team member will look at this issue soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants