Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: handle computed properties in camelcase (fixes #11084) #11113

Merged
merged 1 commit into from Dec 22, 2018

Conversation

madbence
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Tell us about your environment

  • ESLint Version: 5.9.0
  • Node Version: 11.0.0
  • npm Version: 6.4.1

What parser (default, Babel-ESLint, etc.) are you using? default

Please show your full configuration:

Configuration
camelcase: [2, {ignoreDestructuring: true}]

What did you do? Please include the actual source code causing the issue.

var { [category_id]: categoryId } = query;

What did you expect to happen?

Reported camelcase error for category_id.

What actually happened? Please include the actual, raw output from ESLint.

No errors reported

What changes did you make? (Give an overview)

isInsideObjectPattern now stops at computed properties (as the computed property can be a simple expression, and node cannot be part of an ObjectPattern anymore).

Is there anything you'd like reviewers to focus on?

I'd be happy to add more tests if you can think of more edge-cases.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Nov 21, 2018
@platinumazure platinumazure added bug ESLint is working incorrectly rule Relates to ESLint's core rules evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Nov 21, 2018
@platinumazure
Copy link
Member

Note to merger: This should be merged as an "Update" since this is a bugfix that adds more warnings.

@not-an-aardvark not-an-aardvark added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Dec 8, 2018
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@not-an-aardvark
Copy link
Member

@madbence It seems like there are some merge conflicts. Would you mind fixing those?

@madbence
Copy link
Contributor Author

sure!

@madbence
Copy link
Contributor Author

@not-an-aardvark is anything left i could do? 😸

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@platinumazure platinumazure merged commit 4242314 into eslint:master Dec 22, 2018
@madbence madbence deleted the issue-11084 branch December 24, 2018 13:10
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jun 21, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants