Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Move ignored-paths, report-translator to lib/util (refs #10559) #11116

Merged
merged 2 commits into from Nov 28, 2018

Conversation

platinumazure
Copy link
Member

@platinumazure platinumazure commented Nov 22, 2018

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Moving files that are not part of public Node.js API to lib/util folder

Refs #10559.

What changes did you make? (Give an overview)

Moved lib/ignored-paths to lib/util/ignored-paths, and lib/report-translator to lib/util/report-translator.

Is there anything you'd like reviewers to focus on?

Not really.

@platinumazure platinumazure added core Relates to ESLint's core APIs and features accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing labels Nov 22, 2018
@platinumazure platinumazure changed the title Chore: Move ignored-paths and report-translator to lib/util (refs #10559) Chore: Move ignored-paths, report-translator to lib/util (refs #10559) Nov 22, 2018
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@platinumazure platinumazure merged commit bc50dc7 into master Nov 28, 2018
@platinumazure platinumazure deleted the move-to-utils branch November 28, 2018 22:21
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators May 28, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label May 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing core Relates to ESLint's core APIs and features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants