Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: (Grammar) "the setup" -> "to set up". #11117

Merged
merged 1 commit into from Nov 23, 2018
Merged

Docs: (Grammar) "the setup" -> "to set up". #11117

merged 1 commit into from Nov 23, 2018

Conversation

MarvinJWendt
Copy link
Contributor

@MarvinJWendt MarvinJWendt commented Nov 22, 2018 •
edited

What is the purpose of this pull request? (put an "X" next to item)

  • Documentation update
  • Bug fix (template)
  • New rule (template)
  • Changes an existing rule (template)
  • Add autofixing to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain: Fixed a typo.

What changes did you make? (Give an overview)
I fixed the typo to setup.
setup is a noun. The correct verb is to set up

Source:

Is there anything you'd like reviewers to focus on?
No

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Nov 22, 2018
platinumazure
platinumazure approved these changes Nov 22, 2018
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Note to merger: The commit summary should be prefixed with "Docs:".

@MarvinJWendt MarvinJWendt changed the title Grammar fix: the setup -> to set up Fix: (Grammar) "the setup" -> "to set up". Nov 22, 2018
@MarvinJWendt MarvinJWendt changed the title Fix: (Grammar) "the setup" -> "to set up". Docs: (Grammar) "the setup" -> "to set up". Nov 22, 2018
@aladdin-add aladdin-add merged commit a675c89 into eslint:master Nov 23, 2018
@aladdin-add
Copy link
Member

merged, thanks for contributing!

@MarvinJWendt MarvinJWendt deleted the grammar-fix branch November 23, 2018 17:33
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators May 23, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label May 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@platinumazure platinumazure platinumazure approved these changes

@aladdin-add aladdin-add aladdin-add approved these changes

Assignees
No one assigned
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion triage An ESLint team member will look at this issue soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MarvinJWendt @aladdin-add @platinumazure