Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: deprecate valid-jsdoc and require-jsdoc #11145

Merged
merged 1 commit into from Dec 7, 2018

Conversation

not-an-aardvark
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain:

What changes did you make? (Give an overview)

Also see: https://eslint.org/blog/2018/11/jsdoc-end-of-life

This deprecates the valid-jsdoc and require-jsdoc rules. We are currently still using them to lint the ESLint codebase -- at some point we should probably switch to eslint-plugin-jsdoc to dogfood the process.

Is there anything you'd like reviewers to focus on?

Nothing in particular

Also see: https://eslint.org/blog/2018/11/jsdoc-end-of-life

This deprecates the `valid-jsdoc` and `require-jsdoc` rules. We are currently still using them to lint the ESLint codebase -- at some point we should probably switch to `eslint-plugin-jsdoc` to dogfood the process.
@not-an-aardvark not-an-aardvark added enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion labels Dec 1, 2018
@aladdin-add aladdin-add mentioned this pull request Dec 1, 2018
4 tasks
@not-an-aardvark not-an-aardvark merged commit 4490d7a into master Dec 7, 2018
@not-an-aardvark not-an-aardvark deleted the deprecate-jsdoc branch December 7, 2018 21:21
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jun 6, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants