Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: fix some jsdoc-related issues in the codebase #11148

Merged
merged 1 commit into from Dec 2, 2018

Conversation

aladdin-add
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x ] Other, please explain:
the fixes some jsdoc-related issues in eslint codebase.

What changes did you make? (Give an overview)

  • enable prefer "Araray" in valid-jsdoc (and fixes the errors)
  • removed some unused params in jsdoc.
  • fixes some incorrect params.

Is there anything you'd like reviewers to focus on?

it would be helpful to switch to eslint-plugin-jsdoc.

@aladdin-add aladdin-add added the chore This change is not user-facing label Dec 1, 2018
@aladdin-add aladdin-add merged commit 4bcdfd0 into eslint:master Dec 2, 2018
@aladdin-add aladdin-add deleted the fix/jsdoc branch December 2, 2018 07:15
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jun 1, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants