Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: Espree v5.0.0 #11161

Merged
merged 1 commit into from Dec 8, 2018
Merged

Upgrade: Espree v5.0.0 #11161

merged 1 commit into from Dec 8, 2018

Conversation

kaicataldo
Copy link
Member

@kaicataldo kaicataldo commented Dec 5, 2018

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:

Upgrading to Espree v5.0.0 (which removes comment attachment).

What changes did you make? (Give an overview)
Upgrade espree from ^4.0.0 to ^5.0.0.

Is there anything you'd like reviewers to focus on?
Nothing in particular.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Dec 5, 2018
@kaicataldo kaicataldo added upgrade This change is related to a dependency upgrade and removed triage An ESLint team member will look at this issue soon labels Dec 5, 2018
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jaydenseric
Copy link

Hopefully it will fix this warning on installation:

npm WARN acorn-jsx@5.0.1 requires a peer of acorn@^6.0.0 but none is installed. You must install peer dependencies yourself.
$ npm ls acorn-jsx
[redacted]
└─┬ eslint@5.9.0
  └─┬ espree@4.1.0
    └── acorn-jsx@5.0.1
$ npm ls acorn
[redacted]
└─┬ next@7.0.2
  └─┬ webpack@4.20.2
    ├── acorn@5.7.3
    └─┬ acorn-dynamic-import@3.0.0
      └── acorn@5.7.3  deduped

@platinumazure
Copy link
Member

@jaydenseric It won't, as this is an npm bug (see this comment for more information).

@not-an-aardvark not-an-aardvark merged commit f850726 into master Dec 8, 2018
@not-an-aardvark not-an-aardvark deleted the espreev5 branch December 8, 2018 02:59
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jun 7, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion upgrade This change is related to a dependency upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants