Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix link to rule no-useless-rename #11165

Merged
merged 1 commit into from Dec 6, 2018
Merged

Docs: Fix link to rule no-useless-rename #11165

merged 1 commit into from Dec 6, 2018

Conversation

thisBrian
Copy link
Contributor

@thisBrian thisBrian commented Dec 6, 2018

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update

What changes did you make? (Give an overview)
Fixed link to rule: no-useless-rename that erroneously linked to the same currently viewed rule: object-shorthand

Is there anything you'd like reviewers to focus on?
Trivial fix.

@jsf-clabot
Copy link

jsf-clabot commented Dec 6, 2018

CLA assistant check
All committers have signed the CLA.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Dec 6, 2018
@thisBrian thisBrian changed the title fix link to rule: no-useless-rename Docs: fix link to rule: no-useless-rename Dec 6, 2018
@thisBrian thisBrian changed the title Docs: fix link to rule: no-useless-rename Docs: Fix link to rule no-useless-rename Dec 6, 2018
@aladdin-add aladdin-add added bug ESLint is working incorrectly documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Dec 6, 2018
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

(Note to merger: Ensure PR title is used in commit summary)

@aladdin-add aladdin-add merged commit 958987a into eslint:master Dec 6, 2018
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jun 20, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants