Docs: Fix no-irregular-whitespace description #11196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
ilyavolodin
approved these changes
Dec 15, 2018
platinumazure
approved these changes
Dec 15, 2018
There was a problem hiding this comment.
LGTM, thanks!
I'm okay with the description being general, rather than alluding to specific rule options. If we allude to one or two options, the temptation is to keep changing the description. What you've proposed here is clear and succinct.
Thanks for contributing!
platinumazure
added
rule
|
Thanks for contributing! |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Documentation update
What changes did you make? (Give an overview)
I updated the description to be correct (irregular whitespace is forbidden in comments by default) and match nearby rules in the rule list which didn’t elaborate.
Is there anything you'd like reviewers to focus on?
Should I add back “outside of strings?”