Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Remove a misleading example #11204

Merged
merged 1 commit into from Dec 22, 2018

Conversation

gion
Copy link
Contributor

@gion gion commented Dec 21, 2018

Remove one of the misleading examples for incorrect usage

What is the purpose of this pull request? (put an "X" next to item)

  • Documentation update
  • Bug fix (template)
  • New rule (template)
  • Changes an existing rule (template)
  • Add autofixing to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain:

What changes did you make? (Give an overview)
This PR removes a misleading example of incorrect padded-blocks rule configured with the "always" option.
The following statement is actually a correct usage for the rule when configured with "always"

 if (a) {	
 	
     b();	
 }	

Is there anything you'd like reviewers to focus on?

Remove one of the misleading examples for incorrect usage
@jsf-clabot
Copy link

jsf-clabot commented Dec 21, 2018

CLA assistant check
All committers have signed the CLA.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Dec 21, 2018
@platinumazure platinumazure added rule Relates to ESLint's core rules documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Dec 21, 2018
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@platinumazure platinumazure merged commit 8abc8af into eslint:master Dec 22, 2018
@gion
Copy link
Contributor Author

gion commented Jan 3, 2019

my pleasure 👍

@gion gion deleted the docs/fix-padded-blocks branch January 3, 2019 09:35
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jun 21, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants