Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: handle optional catch bindings in no-useless-catch (fixes #11208) #11205

Merged
merged 1 commit into from Dec 25, 2018
Merged

Fix: handle optional catch bindings in no-useless-catch (fixes #11208) #11205

merged 1 commit into from Dec 25, 2018

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 23, 2018

When optional catch bindings are used, node.param is null.

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Added a missing check in no-useless-catch.

Is there anything you'd like reviewers to focus on?
No

@jsf-clabot
Copy link

jsf-clabot commented Dec 23, 2018 •
edited

CLA assistant check
All committers have signed the CLA.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Dec 23, 2018
not-an-aardvark
not-an-aardvark suggested changes Dec 23, 2018
View reviewed changes
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, may you please add a test?

@not-an-aardvark not-an-aardvark added bug ESLint is working incorrectly rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion patch candidate This issue may necessitate a patch release in the next few days and removed triage An ESLint team member will look at this issue soon labels Dec 23, 2018
@cjihrig
Fix: handle optional catch bindings in no-useless-catch
f0688aa 
This commit prevents a crash in the no-useless-catch rule
that occurs when optional catch bindings are used.
@cjihrig
Copy link
Contributor Author

cjihrig commented Dec 23, 2018

@not-an-aardvark I've added a test.

platinumazure
platinumazure approved these changes Dec 23, 2018
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

not-an-aardvark
not-an-aardvark approved these changes Dec 23, 2018
View reviewed changes
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add mentioned this pull request Dec 25, 2018
Closed
@aladdin-add aladdin-add changed the title Fix: handle optional catch bindings in no-useless-catch Fix: handle optional catch bindings in no-useless-catch (fixes#11208) Dec 25, 2018
@aladdin-add aladdin-add changed the title Fix: handle optional catch bindings in no-useless-catch (fixes#11208) Fix: handle optional catch bindings in no-useless-catch (fixes #11208) Dec 25, 2018
@platinumazure platinumazure merged commit de79f10 into eslint:master Dec 25, 2018
@cjihrig cjihrig deleted the patch-1 branch December 25, 2018 20:03
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jun 24, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@platinumazure platinumazure platinumazure approved these changes

@not-an-aardvark not-an-aardvark not-an-aardvark approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly patch candidate This issue may necessitate a patch release in the next few days rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cjihrig @jsf-clabot @platinumazure @not-an-aardvark