Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: eslint-plugin-eslint-plugin@2.0.1 #11220

Merged
merged 2 commits into from Jan 4, 2019
Merged

Conversation

aladdin-add
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)
upgrade eslint-plugin-eslint-plugin@2.0.1, it mainly added a new rule: require-meta-type.

Is there anything you'd like reviewers to focus on?
thoughts on the types of internal rules?

@aladdin-add aladdin-add added the upgrade This change is related to a dependency upgrade label Dec 29, 2018
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basic changes LGTM, thanks!

Regarding rule types for internal rules: I think suggestion makes sense for most of them, but I left a suggestion on one that I think should be a problem. Let me know what you think. Thanks!

tools/internal-rules/no-invalid-meta.js Outdated Show resolved Hide resolved
Copy link
Member

@btmills btmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@btmills
Copy link
Member

btmills commented Jan 4, 2019

Closing and reopening to see if it'll wake up the CLA checker.

@btmills btmills closed this Jan 4, 2019
@btmills btmills reopened this Jan 4, 2019
@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Not sure what's wrong with the CLA checker-- are you using a new e-mail address in some of your commits?

@btmills
Copy link
Member

btmills commented Jan 4, 2019

It looks like the second commit was made from within the GitHub UI, and it formatted the commit's author name differently. Since the email address is identical, we'll consider them to be the same.

@btmills btmills merged commit 166853d into master Jan 4, 2019
@not-an-aardvark not-an-aardvark deleted the upgrade/eslint-plugin branch January 4, 2019 20:35
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jul 4, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jul 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion upgrade This change is related to a dependency upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants