Fix: Manage severity of 1 with TAP reporter (fixes #11110) #11221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
platinumazure
added
bug
platinumazure
requested changes
Dec 29, 2018
There was a problem hiding this comment.
Thanks for contributing! I've identified one typo.
I also have two other thoughts:
- The string "not ok" does have the string "ok" in it, so do we want to be more specific about asserting that the formatter does not say "not ok"? (If a message says "not ok", then
assert.include(message, "ok")will still be true, so any regression might not be caught!) - Are there tests which show results for all errors, or a mix of warnings and errors? For the latter, I think I would expect a change (ok on warnings, not ok on errors), so it seems a new test should be added.
Let me know if you have any questions. Thanks again for working on this!
tests/lib/formatters/tap.js
Outdated
| }] | ||
| }]; | ||
|
|
||
| it("should return a an warning string", () => { |
When using TAP reporter, both messages with severity of 1 or 2 were listed as errors (`not ok`). This changes aims at reporting warnings as `ok` messages.
GabrielCousin
force-pushed
the
issue11110
branch
from
1952cd5
to
5908433
Compare
|
Thanks for your feedback! First point must be fixed :) |
|
@platinumazure Friendly ping; has your feedback been addressed? |
platinumazure
approved these changes
Jan 4, 2019
nzakas
approved these changes
Jan 16, 2019
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
As reported in #11110, result with severity of 1 (ie. warning) were reported as errors (not ok)
This will allow:
oknot okIs there anything you'd like reviewers to focus on?
Nothing!