Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indent rule with VariableDeclarator set to "first" #11265

Closed
bmblb opened this issue Jan 11, 2019 · 3 comments
Closed

Indent rule with VariableDeclarator set to "first" #11265

bmblb opened this issue Jan 11, 2019 · 3 comments
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion auto closed The bot closed this issue bug ESLint is working incorrectly triage An ESLint team member will look at this issue soon

Comments

@bmblb
Copy link

bmblb commented Jan 11, 2019

Tell us about your environment

  • ESLint Version:
    5.12.0
  • Node Version:
    8.13.0
  • npm Version:
    6.4.1

What parser (default, Babel-ESLint, etc.) are you using?
default

Hello. I am trying VariableDeclarator: first option for indent rule and it breaks alignment.
This is the example of correct code:

let a = {
        a : 1,
        b : 2
    },
    b = 2,
    c = 3;

const d = {
        a : 1,
        b : 2
    },
    e = 3;

When I add rule indent: ["error", 4, { "VariableDeclarator": "first" }], eslint consider code above invalid and changes it to below:

/* eslint indent: ["error", 4, { "VariableDeclarator": "first" }] */
let a = {
    a : 1,
    b : 2
},
    b = 2,
    c = 3;

const d = {
    a : 1,
    b : 2
},
      e = 3;
@bmblb bmblb added bug ESLint is working incorrectly triage An ESLint team member will look at this issue soon labels Jan 11, 2019
@bmblb
Copy link
Author

bmblb commented Jan 11, 2019

Related PR: #11193
@g-plane could you take a look?

@eslint-deprecated eslint-deprecated bot added the auto closed The bot closed this issue label Feb 12, 2019
@eslint-deprecated
Copy link

Unfortunately, it looks like there wasn't enough interest from the team
or community to implement this change. While we wish we'd be able to
accommodate everyone's requests, we do need to prioritize. We've found
that issues failing to reach accepted status after 21 days tend to
never be accepted, and as such, we close those issues.
This doesn't mean the idea isn't interesting or useful, just that it's
not something the team can commit to.

Thanks for contributing to ESLint and we appreciate your understanding.

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Aug 12, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion auto closed The bot closed this issue bug ESLint is working incorrectly triage An ESLint team member will look at this issue soon
Projects
None yet
Development

No branches or pull requests

2 participants