Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: increase camelcase test coverage #11299

Merged
merged 1 commit into from Feb 1, 2019

Conversation

RedTn
Copy link
Contributor

@RedTn RedTn commented Jan 21, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:

Increase test coverage

What changes did you make? (Give an overview)

Increase test coverage in lib/rules/camelcase.js by writing test cases that hit missing branches/statements

Is there anything you'd like reviewers to focus on?
Coverage added in this screenshot
image

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Jan 21, 2019
@RedTn RedTn force-pushed the test/camelcase-increase-coverage branch from b463091 to 711d194 Compare January 21, 2019 02:52
@RedTn RedTn changed the title test(camelcase): increase test coverage Chore: increase camelcase test coverage Jan 21, 2019
@g-plane g-plane added rule Relates to ESLint's core rules evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion chore This change is not user-facing and removed triage An ESLint team member will look at this issue soon labels Jan 21, 2019
@not-an-aardvark not-an-aardvark added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Feb 1, 2019
@ilyavolodin ilyavolodin merged commit 9005e63 into eslint:master Feb 1, 2019
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Aug 1, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants