Chore: avoid hard-coding the list of core rules in eslint:recommended #11336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the `eslint:recommended` config to be generated dynamically rather than being hard-coded, to reduce the number of places that need to be kept up to date when core rules are added.
g-plane
reviewed
Jan 30, 2019
| "yield-star-spacing": "off", | ||
| yoda: "off" | ||
| } | ||
| rules: Object.assign({}, ...Object.keys(builtInRules).map(ruleId => ({ |
There was a problem hiding this comment.
Using Array.prototype.reduce can remove Object.assign and Array.prototype.map. And there is only one {} while using Object.assign needs many objects.
There was a problem hiding this comment.
I don't feel strongly about it either way, but I think using Object.assign here is better because it's not necessary to mutate an accumulator object, and it's still O(n). Creating the extra objects is a one-time cost that only happens when the module is loaded.
aladdin-add
approved these changes
Jan 30, 2019
ilyavolodin
approved these changes
Jan 30, 2019
|
I've verified that the website generation and the demo both use the entire list of rules and check the |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
What changes did you make? (Give an overview)
This updates the
eslint:recommendedconfig to be generated dynamically rather than being hard-coded, to reduce the number of places that need to be kept up to date when core rules are added.Is there anything you'd like reviewers to focus on?
I was considering doing the same thing for
tools/rule-types.json, but after looking at it again I'm not actually sure whytools/rule-types.jsonexists at all. Is there a reason to keep that file around? It was useful for reviewing the original PR that added rule types, but it doesn't seem like the rule types file is being used for anything.