New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: add rule "prefer-named-capture-group" (fixes #11381) #11392
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
The direction looks good to me.
But I have some suggestions, would you address those?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! I have a few suggestions/questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM outside of the rule message being a little verbose. I've offered a suggestion but open to tweaks.
Co-Authored-By: g-plane <g-plane@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks so much for making the change!
As a note, the CI is broken due to a bug in the eslint-scope upgrade which we're still investigating. Thanks for your patience! |
Closing/reopening to force rerun of CI. |
Merged (at last). Thanks @g-plane for contributing! |
What is the purpose of this pull request? (put an "X" next to item)
[x] New rule
What changes did you make? (Give an overview)
Added a new rule called "require-named-capture-group".
Fixes #11381
Is there anything you'd like reviewers to focus on?