Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: switch from browserify to webpack (fixes #11366) #11398

Merged
merged 9 commits into from Feb 18, 2019
Merged

Build: switch from browserify to webpack (fixes #11366) #11398

merged 9 commits into from Feb 18, 2019

Conversation

g-plane
Copy link
Member

@g-plane g-plane commented Feb 15, 2019 •
edited

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain: Changes related to build

What changes did you make? (Give an overview)
Removed browserify, and added webpack, which brought smaller bundle size (not too much). And, build time should be reduced.

Is there anything you'd like reviewers to focus on?
Maybe the Makefile.js and webpack.config.js.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Feb 15, 2019
@g-plane g-plane added build This change relates to ESLint's build process evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Feb 15, 2019
not-an-aardvark
not-an-aardvark reviewed Feb 15, 2019
View reviewed changes
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from a small suggestion. Thanks!

webpack.config.js Outdated Show resolved Hide resolved
aladdin-add
aladdin-add requested changes Feb 15, 2019
View reviewed changes
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just have a few questions. I have wanted to see it happen for a while, thanks for doing this! 😄

webpack.config.js Show resolved Hide resolved
Makefile.js Outdated Show resolved Hide resolved
karma.conf.js Show resolved Hide resolved
@g-plane g-plane mentioned this pull request Feb 16, 2019
Merged
not-an-aardvark
not-an-aardvark approved these changes Feb 16, 2019
View reviewed changes
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

aladdin-add
aladdin-add approved these changes Feb 16, 2019
View reviewed changes
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

ilyavolodin
ilyavolodin suggested changes Feb 16, 2019
View reviewed changes
Makefile.js Outdated Show resolved Hide resolved
nzakas
nzakas approved these changes Feb 18, 2019
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting!

@nzakas nzakas mentioned this pull request Feb 18, 2019
Closed
@aladdin-add aladdin-add added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Feb 18, 2019
btmills
btmills approved these changes Feb 18, 2019
View reviewed changes
Copy link
Member

@btmills btmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One idea for potentially speeding up the build and reducing its size by tuning the presets, but certainly not a ship-stopper, and it could easily be done in a future PR once we have the right information.

webpack.config.js Show resolved Hide resolved
@aladdin-add aladdin-add mentioned this pull request Feb 18, 2019
Closed
@aladdin-add aladdin-add merged commit db0c5e2 into master Feb 18, 2019
@aladdin-add aladdin-add deleted the use-webpack branch February 18, 2019 18:03
@snyk-bot snyk-bot mentioned this pull request Aug 15, 2019
Merged
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Aug 18, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@btmills btmills btmills approved these changes

@aladdin-add aladdin-add aladdin-add approved these changes

@nzakas nzakas nzakas approved these changes

@ilyavolodin ilyavolodin ilyavolodin approved these changes

@not-an-aardvark not-an-aardvark not-an-aardvark approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion build This change relates to ESLint's build process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@g-plane @nzakas @ilyavolodin @btmills @not-an-aardvark @aladdin-add