Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint v5.14.0 now requires Node.js to be compiled with crypto #11413

Assignees
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation infrastructure Relates to the tools used in the ESLint development process

Comments

@nzakas
Copy link
Member

nzakas commented Feb 18, 2019

I came across this on Twitter. It appears that upgrading file-entry-cache means that ESLint now requires Node.js to be compiled with crypto because of how the cache is generated now. More details:

nodejs/node#26182

We should decide if this is something we are okay with going forward.

I’m guessing there aren’t a lot of folks using Node.js without crypto, so maybe not a big deal, but at a minimum it seems like we should acknowledge this requirement in our docs somewhere.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Feb 18, 2019
@aladdin-add aladdin-add added documentation Relates to ESLint's documentation infrastructure Relates to the tools used in the ESLint development process and removed triage An ESLint team member will look at this issue soon labels Feb 19, 2019
@eslint-deprecated eslint-deprecated bot added the auto closed The bot closed this issue label Mar 22, 2019
@eslint-deprecated
Copy link

Unfortunately, it looks like there wasn't enough interest from the team
or community to implement this change. While we wish we'd be able to
accommodate everyone's requests, we do need to prioritize. We've found
that issues failing to reach accepted status after 21 days tend to
never be accepted, and as such, we close those issues.
This doesn't mean the idea isn't interesting or useful, just that it's
not something the team can commit to.

Thanks for contributing to ESLint and we appreciate your understanding.

@platinumazure
Copy link
Member

@nzakas Do we need to reopen this?

@nzakas nzakas self-assigned this Mar 22, 2019
@nzakas nzakas removed the auto closed The bot closed this issue label Mar 22, 2019
@nzakas
Copy link
Member Author

nzakas commented Mar 22, 2019

Yes, thanks for catching this! I filed it on mobile which didn't allow me to set an assignee, and it fell off my radar.

@nzakas nzakas reopened this Mar 22, 2019
@kaicataldo
Copy link
Member

Related issue from a while back: #5522

How do we want to proceed with this? Should we maybe bring this up in the next TSC meeting? Given we haven't seen any other issues, it doesn't seem like it's a widespread problem. That being said, if it's something that's easily fixable it could be worth changing to make it easier for Node core's tests.

@kaicataldo
Copy link
Member

Is this something we still need to look at?

@nzakas
Copy link
Member Author

nzakas commented Oct 21, 2019

This is really just a sentence addition to the readme saying that ESLint requires crypto.

@nzakas
Copy link
Member Author

nzakas commented Oct 21, 2019

Submitted #12475

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 22, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.