Chore: enable require-unicode-regexp on ESLint codebase #11422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
approved these changes
Feb 21, 2019
platinumazure
approved these changes
Feb 21, 2019
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
What changes did you make? (Give an overview)
This enables the
require-unicode-regexprule on the ESLint codebase. There were some discussions about possibly adding this rule toeslint:recommended, so I thought it would be worth dogfooding.This change does not start parsing user-provided unicode regexes with the
uflag, because that could be a breaking change. (However, I still think it would be a good idea. I created an issue for it at #11423.)Is there anything you'd like reviewers to focus on?
These changes were applied by temporarily adding an unsound fixer to the
require-unicode-regexprule, runningeslint --fixon the codebase, then removing the fixer before committing.