Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: eslint-config-eslint enable comma-dangle functions: "never" #11434

Merged
merged 2 commits into from Mar 6, 2019

Conversation

aladdin-add
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?
IMHO, this should be enabled by default.

@aladdin-add aladdin-add added the chore This change is not user-facing label Feb 23, 2019
@aladdin-add aladdin-add changed the title Chore: comma-dangle enable functions: "never" Chore: eslint-config-eslint enable comma-dangle functions: "never" Feb 23, 2019
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one suggested change (non-blocker). Thanks!

packages/eslint-config-eslint/default.yml Outdated Show resolved Hide resolved
Co-Authored-By: aladdin-add <weiran.zsd@outlook.com>
@not-an-aardvark not-an-aardvark merged commit 62fee4a into master Mar 6, 2019
@not-an-aardvark not-an-aardvark deleted the aladdin-add-patch-1 branch March 6, 2019 08:08
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Sep 3, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Sep 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants