Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Remove path.resolve in webpack build #11462

Merged
merged 2 commits into from Mar 2, 2019
Merged

Build: Remove path.resolve in webpack build #11462

merged 2 commits into from Mar 2, 2019

Conversation

platinumazure
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Use path.join instead of path.resolve to ensure relative path is passed to Webpack when releasing on the Jenkins server. For some reason, the absolute path is not actually resolved correctly there.

Is there anything you'd like reviewers to focus on?

Not really.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Mar 2, 2019
@platinumazure platinumazure added build This change relates to ESLint's build process accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing and removed triage An ESLint team member will look at this issue soon labels Mar 2, 2019
not-an-aardvark
not-an-aardvark approved these changes Mar 2, 2019
View reviewed changes
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@platinumazure platinumazure changed the title Fix: Use path.join instead of path.resolve in webpack build Build: Use path.join instead of path.resolve in webpack build Mar 2, 2019
@platinumazure platinumazure removed the chore This change is not user-facing label Mar 2, 2019
@platinumazure platinumazure changed the title Build: Use path.join instead of path.resolve in webpack build Build: Remove path.resolve in webpack build Mar 2, 2019
@not-an-aardvark not-an-aardvark merged commit 4088c6c into master Mar 2, 2019
@not-an-aardvark not-an-aardvark deleted the platinumazure-patch-1 branch March 2, 2019 02:22
@snyk-bot snyk-bot mentioned this pull request Aug 15, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Aug 28, 2019
Closed
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Aug 30, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@not-an-aardvark not-an-aardvark not-an-aardvark approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion build This change relates to ESLint's build process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@platinumazure @not-an-aardvark