New: allowAfterThisConstructor for no-underscore-dangle (fixes #11488)

[sripberger]

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Implemented a new option for no_underscore_dangle rule

Is there anything you'd like reviewers to focus on?

See rationale in issue.

[ilyavolodin]

@eslint/eslint-team does anyone else wants to support this? Since we already have an option for super, I think it makes sense. \

[platinumazure]

I'll champion this. I'll try to get two more team members to support this week.

[btmills]

Thanks for this, @sripberger! Leaving this review as "request changes" until we decide whether to change the default or do this as a breaking change in a major version (I'm in favor of the latter).

[btmills]

@sripberger explained why this would not cause new errors, so this can be merged as a semver-minor change.

[mdjermanovic]

This is accepted now.

[platinumazure]

The code/docs/tests look good to me, thanks!

Only one request: If you have time, could you please ensure the commit message says allowAfterThisConstructor rather than allowAfterConstructor?

You can do this one of two ways:

1. Amend the commit on your local branch using git commit --amend, then force push to the remote branch with git push origin issue11488 --force
2. Push another commit with some other change to this branch, then change the PR title

Thanks!

---

EDIT: Thinking about it, we could also just fix that on merge. But if you have time to fix the message on your end, it will reduce the chance of a mistake on our end. 😄

[sripberger]

The code/docs/tests look good to me, thanks!

Only one request: If you have time, could you please ensure the commit message says allowAfterThisConstructor rather than allowAfterConstructor?

You can do this one of two ways:

1. Amend the commit on your local branch using git commit --amend, then force push to the remote branch with git push origin issue11488 --force
2. Push another commit with some other change to this branch, then change the PR title

Thanks!

EDIT: Thinking about it, we could also just fix that on merge. But if you have time to fix the message on your end, it will reduce the chance of a mistake on our end.

I'll go ahead and to the force push since that's alright with you. Will be easiest.

[platinumazure]

Looks good, thanks for contributing!

[platinumazure]

I've gone ahead and merged this. Thanks so much for the rule enhancement! I apologize for the significant delay on accepting and merging this.