Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid JSON in "Specifying Parser Options" #11492

Merged
merged 1 commit into from Mar 8, 2019
Merged

Fix invalid JSON in "Specifying Parser Options" #11492

merged 1 commit into from Mar 8, 2019

Conversation

tinymachine
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Fixed missing quotes in the JSON snippets in this line:

{ env: { es6: true } } enables ES6 syntax automatically, but { parserOptions: { ecmaVersion: 6 } } does not enable ES6 globals automatically.

Is there anything you'd like reviewers to focus on?

@jsf-clabot
Copy link

jsf-clabot commented Mar 8, 2019

CLA assistant check
All committers have signed the CLA.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Mar 8, 2019
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@platinumazure platinumazure added documentation Relates to ESLint's documentation core Relates to ESLint's core APIs and features accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Mar 8, 2019
@platinumazure platinumazure merged commit e7266c2 into eslint:master Mar 8, 2019
@platinumazure
Copy link
Member

Thanks @tinymachine for the contribution!

@tinymachine
Copy link
Contributor Author

My pleasure — thanks for your work on this indispensable tool!

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Sep 5, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants