Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: update CI testing configuration #11500

Merged
merged 2 commits into from Mar 13, 2019
Merged

Build: update CI testing configuration #11500

merged 2 commits into from Mar 13, 2019

Conversation

RDIL
Copy link
Contributor

@RDIL RDIL commented Mar 13, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:

  • makes builds go faster
  • removes deprecated option

What changes did you make? (Give an overview)
explained above

Is there anything you'd like reviewers to focus on?
speedy builds with caching :D

@jsf-clabot
Copy link

jsf-clabot commented Mar 13, 2019

CLA assistant check
All committers have signed the CLA.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Mar 13, 2019
@RDIL RDIL changed the title Enable CI npm caching and remove deprecated option Test: update test configuration Mar 13, 2019
@RDIL RDIL changed the title Test: update test configuration Build: update CI testing configuration Mar 13, 2019
@not-an-aardvark
Copy link
Member

Thanks for the pull request!

Removing the deprecated sudo: false option sounds good to me. However, I don't think we should use npm caching because occasionally a dependency upgrade causes the build to break (or causes ESLint to stop working), and it's useful when CI alerts us of that problem/can be used to run the tests with new dependencies.

@RDIL
Copy link
Contributor Author

RDIL commented Mar 13, 2019

Will fix when I get home.

@RDIL
Copy link
Contributor Author

RDIL commented Mar 13, 2019

Fixed @not-an-aardvark

Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing!

@aladdin-add aladdin-add merged commit 06fa165 into eslint:master Mar 13, 2019
@RDIL RDIL deleted the patch-1 branch March 13, 2019 15:46
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Sep 10, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion triage An ESLint team member will look at this issue soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants