Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update no-confusing-arrow with the new default option #11886

Merged
merged 2 commits into from Jun 24, 2019
Merged

Docs: Update no-confusing-arrow with the new default option #11886

merged 2 commits into from Jun 24, 2019

Conversation

zypA13510
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

  • Removed redundant sentence from the summary as the default for allowParens is now true.
  • Updated examples according to the new default.

Is there anything you'd like reviewers to focus on?
N/A

- Remove redundant sentence from the summary as the default for allowParens is now true.
- Update examples according to the new default.
@jsf-clabot
Copy link

jsf-clabot commented Jun 24, 2019

CLA assistant check
All committers have signed the CLA.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Jun 24, 2019
@zypA13510 zypA13510 changed the title Docs: Update examples with the new default option (refs #11503) Docs: Update no-confusing-arrow with the new default option Jun 24, 2019
Copy link
Member

@g-plane g-plane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one change requesting. Other changes look good, thanks!

docs/rules/no-confusing-arrow.md Outdated Show resolved Hide resolved
@g-plane g-plane added documentation Relates to ESLint's documentation and removed triage An ESLint team member will look at this issue soon labels Jun 24, 2019
@g-plane
Copy link
Member

g-plane commented Jun 24, 2019

And, please sign our CLA.

- Moved an example from correct to incorrect.
- Added a new correct example.
@zypA13510
Copy link
Contributor Author

Done, also added a new example because it seems appropriate to me.

Copy link
Member

@g-plane g-plane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to ESLint!

@kaicataldo kaicataldo merged commit 566b7aa into eslint:master Jun 24, 2019
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Dec 22, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants