Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: add 'stricter rule config validating' in migrating docs #11905

Merged
merged 2 commits into from Jun 26, 2019
Merged

Docs: add 'stricter rule config validating' in migrating docs #11905

merged 2 commits into from Jun 26, 2019

Conversation

aladdin-add
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update

What changes did you make? (Give an overview)
refs #9505

Is there anything you'd like reviewers to focus on?

wording improvement?

@aladdin-add aladdin-add added documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion labels Jun 25, 2019
@platinumazure platinumazure self-requested a review June 25, 2019 16:50
kaicataldo
kaicataldo reviewed Jun 25, 2019
View reviewed changes
docs/user-guide/migrating-to-6.0.0.md Outdated Show resolved Hide resolved
docs/user-guide/migrating-to-6.0.0.md Outdated Show resolved Hide resolved
docs/user-guide/migrating-to-6.0.0.md Outdated Show resolved Hide resolved
@kaicataldo
Copy link
Member

A few comments, but otherwise LGTM!

kaicataldo
kaicataldo approved these changes Jun 25, 2019
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

platinumazure
platinumazure approved these changes Jun 25, 2019
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

g-plane
g-plane reviewed Jun 26, 2019
View reviewed changes
Copy link
Member

@g-plane g-plane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one suggestion. Other changes look good, thanks!

docs/user-guide/migrating-to-6.0.0.md Show resolved Hide resolved
@kaicataldo kaicataldo merged commit e5f1ccc into eslint:master Jun 26, 2019
@aladdin-add aladdin-add deleted the docs/rule-config-validating branch June 26, 2019 14:36
This was referenced Aug 27, 2019
Merged
Closed
Merged
Merged
This was referenced Sep 12, 2019
Merged
Merged
Merged
@snyk-bot snyk-bot mentioned this pull request Oct 26, 2019
Open
This was referenced Nov 9, 2019
Open
Open
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Dec 24, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@platinumazure platinumazure platinumazure approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

@g-plane g-plane g-plane approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aladdin-add @kaicataldo @platinumazure @g-plane