New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: fix no-extra-parens ignores some nodes #11909
Conversation
I'm not sure but maybe `${(1, 2)}` === "2"
`${1, 2}` === "2" |
|
@g-plane For the sake of discussion, can you share why you believe that shouldn’t be reported? |
@kaicataldo Oh sorry, I misread it since I read it on my phone at that time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
@g-plane Would you resolve conflicts?
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Merged. Thanks for contributing and sorry for the delay! |
What is the purpose of this pull request? (put an "X" next to item)
[x] Bug fix
What changes did you make? (Give an overview)
Fixes #11893 .
Fixes #11906 .
Is there anything you'd like reviewers to focus on?