Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add temporary test files to .gitignore #11978

Merged
merged 1 commit into from Jul 12, 2019
Merged

Chore: Add temporary test files to .gitignore #11978

merged 1 commit into from Jul 12, 2019

Conversation

mdjermanovic
Copy link
Member

[X] Other, please explain:

These temporary files are being created during npm test, and could be accidentally committed:

  • .temp-eslintcache created in tests/bin/eslint.js in describe("cache files")
  • tests/fixtures/autofix-integration/temp.js created in tests/bin/eslint.js in describe("automatically fixing files")

What changes did you make? (Give an overview)

Added both to .gitignore

Is there anything you'd like reviewers to focus on?

Line endings, I got LF will be replaced by CRLF warning.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Jul 12, 2019
@g-plane g-plane added chore This change is not user-facing and removed triage An ESLint team member will look at this issue soon labels Jul 12, 2019
Copy link
Member

@g-plane g-plane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kaicataldo kaicataldo merged commit 2a10856 into eslint:master Jul 12, 2019
@kaicataldo
Copy link
Member

Thanks for contributing!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants