New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: --init with Vue.js failed (fixes #11970) #11985
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one change request, otherwise looks good to me.
Thank you for your review. I updated this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix: #11970
What changes did you make? (Give an overview)
This PR fixes
--init
to work.We didn't seem to test
--init
when we added Vue.js support. It has assumed thatextends
is a string and doesn't include plugin configs.Is there anything you'd like reviewers to focus on?
Nothing in particular.