Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: minor typo #12112

Merged
merged 1 commit into from Aug 18, 2019
Merged

Fix: minor typo #12112

merged 1 commit into from Aug 18, 2019

Conversation

jamesgeorge007
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: fix typo

What changes did you make? (Give an overview)
Fixed minor typo.

Is there anything you'd like reviewers to focus on?
Nope

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Aug 18, 2019
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing!

@jamesgeorge007 jamesgeorge007 changed the title fix(npm-utils): Fix typo Fix: minor typo Aug 18, 2019
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, forgot about the commit message.

Could you please edit the commit message to conform to our commit message guidelines (specifically, it should start with "Chore:" since this isn't a user-facing change)?

If amending the commit and force pushing is a pain, you could also create a second commit and then edit the PR title.

Please see the "commit-message" status check for more details.

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing the commit message!

@platinumazure platinumazure added accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing cli Relates to ESLint's command-line interface and removed triage An ESLint team member will look at this issue soon labels Aug 18, 2019
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing cli Relates to ESLint's command-line interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants