Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: update docs for ecmaVersion 2020 #12120

Merged
merged 2 commits into from Aug 19, 2019
Merged

Docs: update docs for ecmaVersion 2020 #12120

merged 2 commits into from Aug 19, 2019

Conversation

silverwind
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update

What changes did you make? (Give an overview)

Update docs for ecmaVersion: 2020 introduced in fee6acb

@jsf-clabot
Copy link

jsf-clabot commented Aug 19, 2019 •
edited

CLA assistant check
All committers have signed the CLA.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Aug 19, 2019
@g-plane g-plane changed the title update docs for ecmaVersion 2020 Docs: update docs for ecmaVersion 2020 Aug 19, 2019
@g-plane g-plane added documentation Relates to ESLint's documentation and removed triage An ESLint team member will look at this issue soon labels Aug 19, 2019
g-plane
g-plane approved these changes Aug 19, 2019
View reviewed changes
Copy link
Member

@g-plane g-plane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

platinumazure
platinumazure requested changes Aug 19, 2019
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! Just one small change request.

docs/user-guide/configuring.md Outdated Show resolved Hide resolved
platinumazure
platinumazure approved these changes Aug 19, 2019
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

kaicataldo
kaicataldo approved these changes Aug 19, 2019
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this!

@kaicataldo kaicataldo merged commit 4aeeeed into eslint:master Aug 19, 2019
This was referenced Aug 29, 2019
Merged
Merged
This was referenced Sep 12, 2019
Merged
Merged
Merged
@snyk-bot snyk-bot mentioned this pull request Oct 26, 2019
Open
This was referenced Nov 9, 2019
Open
Open
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 16, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@platinumazure platinumazure platinumazure approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

@g-plane g-plane g-plane approved these changes

Assignees
No one assigned
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@silverwind @jsf-clabot @platinumazure @kaicataldo @g-plane