Update: enforceForSequenceExpressions to no-extra-parens (fixes #11916)

[mdjermanovic]

What is the purpose of this pull request? (put an "X" next to item)

[X] Changes an existing rule #11916

New enforceForSequenceExpressions option in no-extra-parens, to avoid conflicts with no-sequences.

When this option is set to false (default is true) no-extra-parens rule does not report extra parens around sequence expressions.

What rule do you want to change?

no-extra-parens

Does this change cause the rule to produce more or fewer warnings?

fewer

How will the change be implemented? (New option, new default behavior, etc.)?

new option

Please provide some example code that this change will affect:

/* eslint  no-extra-parens: "error" */

(a, b);

if ((a, b));

while((a, b));

What does the rule currently do for this code?

3 warnings.

What will the rule do after it's changed?

No warnings if the option is set to false.

/* eslint  no-extra-parens: ["error", "all", { "enforceForSequenceExpressions": false }] */

(a, b);

if ((a, b));

while((a, b));

What changes did you make? (Give an overview)

New option.

Also, unrelated:

• Fixed some tests (typos in error object).
• Fixed TODO from Fix: no-extra-parens autofix with in in a for-loop init (fixes #11706) #11848 in tests, this was waiting for Fix: fix no-extra-parens ignores some nodes #11909.

Is there anything you'd like reviewers to focus on?

Does not account for double parens. I believe that the issue with double parens is not directly related to this option (#12127).

[kaicataldo]

LGTM, thanks!

[btmills]

LGTM, thanks!