Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Document the exception in no-unsafe-negation #12161

Merged
merged 1 commit into from Aug 26, 2019

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Aug 24, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update

What changes did you make? (Give an overview)

no-unsafe-negation allows parenthesized negations, e.g.:

/*eslint no-unsafe-negation: "error"*/

if ((!a) in b) {} // no errors

It's currently undocumented.

This PR documents that as an 'exception'.

Is there anything you'd like reviewers to focus on?

Technically, this might not be 'negating the left operand', which the rule disallows, so this wouldn't be an 'exception', but I think it should be documented either way.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Aug 24, 2019
@mdjermanovic mdjermanovic added the documentation Relates to ESLint's documentation label Aug 25, 2019
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@platinumazure platinumazure added accepted There is consensus among the team that this change meets the criteria for inclusion rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Aug 25, 2019
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@kaicataldo kaicataldo merged commit 6abc7b7 into master Aug 26, 2019
@kaicataldo
Copy link
Member

Thanks for contributing to ESLint!

@mdjermanovic mdjermanovic deleted the nounsafenegation-docs branch August 30, 2019 21:59
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 23, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants