Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: support TypeScript at config initializer (fixes #11789) #12172

Merged
merged 3 commits into from Aug 30, 2019

Conversation

g-plane
Copy link
Member

@g-plane g-plane commented Aug 27, 2019

What is the purpose of this pull request? (put an "X" next to item)

[x] Add a CLI option

What changes did you make? (Give an overview)
Added a new CLI option for TypeScript.

Is there anything you'd like reviewers to focus on?
Should we add a separated CLI option for TypeScript? Or add it to an existing one?

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Aug 27, 2019
@g-plane g-plane added accepted There is consensus among the team that this change meets the criteria for inclusion cli Relates to ESLint's command-line interface enhancement This change enhances an existing feature of ESLint and removed triage An ESLint team member will look at this issue soon labels Aug 27, 2019
@g-plane g-plane marked this pull request as ready for review August 28, 2019 01:03
@aladdin-add aladdin-add self-requested a review August 28, 2019 14:18
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kaicataldo
Copy link
Member

Thanks for contributing!

@kaicataldo kaicataldo merged commit 4c0b70b into master Aug 30, 2019
@g-plane g-plane deleted the issue-11789 branch August 30, 2019 23:35
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 27, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion cli Relates to ESLint's command-line interface enhancement This change enhances an existing feature of ESLint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants