Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: reset to the default color #12174

Merged
merged 1 commit into from Aug 30, 2019
Merged

Fix: reset to the default color #12174

merged 1 commit into from Aug 30, 2019

Conversation

ricardogobbosouza
Copy link
Contributor

@ricardogobbosouza ricardogobbosouza commented Aug 27, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

When we issue a warning on webpack, every warning is yellow and bold.
With eslint-loader and the stylish formatter the first line is different from the others.

webpack-contrib/eslint-loader#292

Is there anything you'd like reviewers to focus on?

@jsf-clabot
Copy link

jsf-clabot commented Aug 27, 2019

CLA assistant check
All committers have signed the CLA.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Aug 27, 2019
@ricardogobbosouza ricardogobbosouza changed the title fix: reset to the default color Fix: reset to the default color Aug 27, 2019
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to test this change? (E.g., a unit test which changes something about chalk before calling the linter, and then we could check the output to make sure the file name does not have the changes?

I'm also wondering if it would make more sense to just call chalk.reset() by itself earlier in the formatter, so we could have a comment and make clear what's going on?

I'm not strongly opposed to merging as is, but I just want to see if we could make some small improvements here. Thanks!

@ricardogobbosouza
Copy link
Contributor Author

@platinumazure I agree, I just changed

@platinumazure platinumazure added bug ESLint is working incorrectly enhancement This change enhances an existing feature of ESLint formatter Relates to the formatters bundled with ESLint and removed triage An ESLint team member will look at this issue soon labels Aug 28, 2019
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly enhancement This change enhances an existing feature of ESLint formatter Relates to the formatters bundled with ESLint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants