Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: enforceForClassMembers option to accessor-pairs (fixes #12063) #12192

Merged
merged 1 commit into from Sep 14, 2019

Conversation

mdjermanovic
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[X] Changes an existing rule #12063

What rule do you want to change?

accessor-pairs

Does this change cause the rule to produce more or fewer warnings?

More if the option is set to true. Default is false.

How will the change be implemented? (New option, new default behavior, etc.)?

New option.

Please provide some example code that this change will affect:

/*eslint accessor-pairs: ["error", { "enforceForClassMembers": true }]*/

class foo {
  set a(bar) {}
}

What does the rule currently do for this code?

Nothing

What will the rule do after it's changed?

Error: "Getter is not present for class setter 'a'."

What changes did you make? (Give an overview)

New option enforceForClassMembers.

Is there anything you'd like reviewers to focus on?

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Aug 30, 2019
@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Aug 30, 2019
@ilyavolodin ilyavolodin merged commit 540296f into master Sep 14, 2019
@ilyavolodin ilyavolodin deleted the accessorpairs-class branch September 14, 2019 01:04
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Mar 13, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants