Fix: patch hole in the no-lone-blocks rule #12193
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix
Tell us about your environment
What parser (default, Babel-ESLint, etc.) are you using?
default
Please show your full configuration:
Configuration
What did you do? Please include the actual source code causing the issue.
There is a hole in the
ES6
logic for theno-lone-blocks
rule. It is set to accept blocks with declarations, but if such a block appears as a lonely child of another block, it should be an error.I've seen this more than once in the wild - I suspect it can (somewhat) easily happen when you extract a piece of logic into a function.
What did you expect to happen?
Such blocks should be flagged as errors by the rule.
What actually happened? Please include the actual, raw output from ESLint.
No error.
What changes did you make? (Give an overview)
Added extra condition and tests to cover this case.
Is there anything you'd like reviewers to focus on?
No.
Is this a breaking change?
No.