Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: OverrideTester basePath (fixes #12032) #12205

Merged
merged 1 commit into from Sep 4, 2019
Merged

Fix: OverrideTester basePath (fixes #12032) #12205

merged 1 commit into from Sep 4, 2019

Conversation

mysticatea
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix

What changes did you make? (Give an overview)

This PR fixes #12032.

The cause was the reuse of OverrideTester instances in spite of mutable.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@mysticatea mysticatea added bug ESLint is working incorrectly core Relates to ESLint's core APIs and features accepted There is consensus among the team that this change meets the criteria for inclusion labels Sep 3, 2019
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mysticatea mysticatea merged commit 21eb904 into master Sep 4, 2019
@mysticatea mysticatea deleted the issue12032 branch September 4, 2019 23:54
@JounQin
Copy link
Contributor

JounQin commented Sep 5, 2019

Can we publish a patch release? This is really awesome!

@mysticatea
Copy link
Member Author

This will be released in the next scheduled release: https://github.com/eslint/eslint/issues?q=is%3Aopen+is%3Aissue+label%3Arelease

@unional
Copy link

unional commented Sep 5, 2019

This only fixes the crash issue, but does not fix how the overrides is handled when it comes from a plugin/config, right?

@mysticatea
Copy link
Member Author

mysticatea commented Sep 5, 2019

Correct. This fixes only the crash caused by the assertion error in overrides[].files testing.

@gziolo
Copy link

gziolo commented Sep 12, 2019

Correct. This fixes only the crash caused by the assertion error in overrides[].files testing.

Should we open an issue for the part which handles the overrides coming from the configs located in npm packages?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

overrides from npm pkg throws due to basePath inconsistent
7 participants