Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Report global Atomics calls in no-obj-calls (fixes #12234) #12258

Merged
merged 1 commit into from Sep 14, 2019

Conversation

mdjermanovic
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix
[X] Changes an existing rule #12234

This PR modifies the no-obj-calls to:

E.g., the rule will not report Math() if the Math is shadowed or turned off.

Also, the rule will not report Reflect() if an ES2015+ environment is not activated (and the variable isn't added manually as a global in the config file or /*global*/). The same applies to Atomics and ES2017+ environment.

What changes did you make? (Give an overview)

Added Atomics to the list of non-callable globals and modified the logic to report only references to defined global variables.

Is there anything you'd like reviewers to focus on?

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Sep 11, 2019
@mdjermanovic
Copy link
Member Author

There are 3 👍 but I'm not sure is the change in this form accepted for a semver-minor?

@mysticatea mysticatea added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Sep 13, 2019
@mysticatea
Copy link
Member

I'm fine with semver-minor (A bug fix in a rule that results in ESLint reporting more errors). Since it just reports runtime error code, I believe it's small risk.

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ilyavolodin ilyavolodin merged commit 37c0fde into master Sep 14, 2019
@ilyavolodin ilyavolodin deleted the issue12234 branch September 14, 2019 00:25
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Mar 13, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants