Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: space-before-function-paren autofix removes comments (fixes #12259) #12264

Merged
merged 1 commit into from Sep 14, 2019

Conversation

mdjermanovic
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix #12259

This PR fixes the space-before-function-paren rule fixer with the "never" option, to:

  • Concatenate block comments instead of removing them.
  • Report error but doesn't fix anything if there is a line comment between.

Example:

Demo link

/* eslint space-before-function-paren:["error", "never"]*/

function foo /* */(){}

function bar /* 1 */
/* 2 */
/* 3 */ (){}

function baz // line comment
(){}

Current autofix behavior:

/* eslint space-before-function-paren:["error", "never"]*/

function foo(){}

function bar(){}

function baz(){}

New autofix behavior:

/* eslint space-before-function-paren:["error", "never"]*/

function foo/* */(){}

function bar/* 1 *//* 2 *//* 3 */(){}

function baz // line comment
(){}

baz is reported, but not auto-fixed.

What changes did you make? (Give an overview)

Modified the fixer to work similar to template-tag-spacing.

Is there anything you'd like reviewers to focus on?

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Sep 12, 2019
@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Sep 12, 2019
Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as aligned the behavior to the existing rules.

I think that we should separate the space style around comments to another rule in the future.

@mysticatea mysticatea merged commit 985c9e5 into master Sep 14, 2019
@mysticatea mysticatea deleted the issue12259 branch September 14, 2019 00:14
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Mar 13, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

space-before-function-paren removes comments when fixing
3 participants