Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: eqeqeq rule reports incorrect locations #12265

Merged
merged 1 commit into from Sep 13, 2019
Merged

Fix: eqeqeq rule reports incorrect locations #12265

merged 1 commit into from Sep 13, 2019

Conversation

mdjermanovic
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix

Tell us about your environment

  • ESLint Version: 6.3.0
  • Node Version: 10.16.0
  • npm Version: 6.9.0

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

Configuration
module.exports = {
  parserOptions: {
    ecmaVersion: 2015,
  }
};

What did you do? Please include the actual source code causing the issue.

Demo link

/* eslint eqeqeq:error */

(a + b) == c;

What did you expect to happen?

1 error with the correct location (column 9)

What actually happened? Please include the actual, raw output from ESLint.

3:7  error  Expected '===' and instead saw '=='  eqeqeq

What changes did you make? (Give an overview)

Changed eqeqeq to find first operator token between, instead of just the first one which could be a paren.

Also, changed the rule to report loc instead of loc.start. One test in cli-engine had to be modified because of that.

Is there anything you'd like reviewers to focus on?

I hope it's ok to change from loc.start to loc, it always looks better in VS Code.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Sep 12, 2019
@mdjermanovic
Copy link
Member Author

Marking as accepted because it's obvious.

@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Sep 12, 2019
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@mysticatea mysticatea merged commit 01da7d0 into master Sep 13, 2019
@mysticatea mysticatea deleted the eqeqeq-loc branch September 13, 2019 22:47
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Mar 12, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants