New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: enable prefer-regex-literals in eslint codebase #12268
Conversation
Is there a reason this is any more a breaking change than other updates we've made to |
if follows the the same policy with just curious what's other popular shared configs' semantic versioning policy? |
This is a breaking change from the perspective of the eslint-config-eslint package, but that doesn't mean we need to hold this behind the ESLint major release. We can release breaking changes to eslint-config-eslint more frequently, because in theory, only the ESLint team needs to update packages to consume the new configuration. And even if not, users have to choose to use eslint-config-eslint (and install it as its own package), so users should know the semver rules and should understand what they are choosing to do if they use that package. On the other hand, updating eslint:recommended changes the recommended experience right in ESLint itself and it's not a separate package. So any changes made there must be semver-major in ESLint itself (although there are exceptions for removing rules from recommended, noted explicitly in our semver policy). |
What is the purpose of this pull request? (put an "X" next to item)
[ x] Other, please explain:
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
this is a breaking change in eslint-config-eslint.