Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-useless-rename should also report pattern properties with default values #12301

Closed
mdjermanovic opened this issue Sep 22, 2019 · 2 comments · Fixed by #12322, GrabarzUndPartner/gp-vue-boilerplate#260, GrabarzUndPartner/gp-vue-boilerplate#261, thinkwee/thinkwee.github.io#28 or WealthWizardsEngineering/service-registry#12
Closed

no-useless-rename should also report pattern properties with default values #12301

mdjermanovic opened this issue Sep 22, 2019 · 2 comments · Fixed by #12322, GrabarzUndPartner/gp-vue-boilerplate#260, GrabarzUndPartner/gp-vue-boilerplate#261, thinkwee/thinkwee.github.io#28 or WealthWizardsEngineering/service-registry#12
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules

Comments

@mdjermanovic
Copy link
Member

What rule do you want to change?

no-useless-rename

Does this change cause the rule to produce more or fewer warnings?

more

How will the change be implemented? (New option, new default behavior, etc.)?

New default behavior, because I think this is more a bug than an enhancement.

But, there is a question would it be okay for a semver-minor release.

Please provide some example code that this change will affect:

/* eslint no-useless-rename:error */

const { a: a = 1 } = foo;

What does the rule currently do for this code?

Nothing.

What will the rule do after it's changed?

Error, same as for const { a: a } = foo; and autofix to:

/* eslint no-useless-rename:error */

const { a = 1 } = foo;

Are you willing to submit a pull request to implement this change?

Yes.
@mdjermanovic mdjermanovic added bug ESLint is working incorrectly enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Sep 22, 2019
@kaicataldo
Copy link
Member

I agree that this is a good candidate for a semver-minor bug fix. I can’t think of a good reason why the two cases illustrated above should result in different errors.

@kaicataldo
Copy link
Member

I've verified this using the ESLint demo.

@kaicataldo kaicataldo added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Sep 27, 2019
kaicataldo added a commit that referenced this issue Sep 27, 2019
@kaicataldo
Update: no-useless-rename also reports default values (fixes #12301)
3a00488
@kaicataldo kaicataldo mentioned this issue Sep 27, 2019
Merged
kaicataldo added a commit that referenced this issue Sep 27, 2019
@kaicataldo
Update: no-useless-rename also reports default values (fixes #12301)
18b41ed
kaicataldo added a commit that referenced this issue Sep 28, 2019
@kaicataldo
Update: no-useless-rename also reports default values (fixes #12301)
9905f36
kaicataldo added a commit that referenced this issue Sep 29, 2019
@kaicataldo
Update: no-useless-rename also reports default values (fixes #12301)
c6da1e4
platinumazure pushed a commit that referenced this issue Sep 29, 2019
@kaicataldo @platinumazure
Update: no-useless-rename also reports default values (fixes #12301) (#…
334ca7c 
…12322)

* Update: no-useless-rename also reports default values (fixes #12301)

* Refactor
This was referenced Oct 8, 2019
Merged
Merged
Closed
This was referenced Oct 22, 2019
Merged
Open
This was referenced Nov 9, 2019
Open
Open
@snyk-bot snyk-bot mentioned this issue Nov 21, 2019
Merged
@snyk-bot snyk-bot mentioned this issue Feb 27, 2020
Merged
@a-martynovich a-martynovich mentioned this issue Mar 10, 2020
Merged
This was referenced Mar 11, 2020
Merged
Open
@snyk-bot snyk-bot mentioned this issue Mar 26, 2020
Merged
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Mar 29, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update: no-useless-rename also reports default values (fixes #12301) eslint/eslint
[Snyk] Upgrade eslint from 6.4.0 to 6.5.0 GrabarzUndPartner/gp-vue-boilerplate
[Snyk] Upgrade eslint from 6.5.0 to 6.5.1 GrabarzUndPartner/gp-vue-boilerplate
[Snyk] Upgrade eslint from 6.3.0 to 6.5.1 thinkwee/thinkwee.github.io
[Snyk] Upgrade eslint from 6.3.0 to 6.6.0 WealthWizardsEngineering/service-registry
[Snyk] Upgrade eslint from 5.15.1 to 6.8.0 alxtford/numconv
[Snyk] Upgrade eslint from 6.0.0 to 6.8.0 WoTTsecurity/api
[Snyk] Upgrade eslint from 6.0.0 to 6.8.0 WealthWizardsEngineering/instance-terminator
[Snyk] Upgrade eslint from 6.5.0 to 6.8.0 nodeshift/openshift-rest-client
[Snyk] Upgrade eslint from 6.0.0 to 6.8.0 jamesleesaunders/d3-interpolate-curve
2 participants
@kaicataldo @mdjermanovic