Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Fix handling of chained new expressions in new-parens #12303

Merged
merged 1 commit into from Sep 29, 2019

Conversation

mdjermanovic
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix

This bug fix can produce more errors by the new-parens rule in some cases. Also fixes wrong autofix in some other cases.

Tell us about your environment

  • ESLint Version: 6.4.0
  • Node Version: 10.16.0
  • npm Version: 6.9.0

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

Configuration
module.exports = {
  parserOptions: {
    ecmaVersion: 2015,
  }
};

What did you do? Please include the actual source code causing the issue.

Demo link 1

/* eslint new-parens:["error", "always"] */

new new foo();

Demo link 2

/* eslint new-parens:["error", "never"] */

new new foo();

What did you expect to happen?

1 error and the following autofix for the first example:

/* eslint new-parens:["error", "always"] */

new new foo()();

1 error and the following autofix for the second example:

/* eslint new-parens:["error", "never"] */

new (new foo);

What actually happened? Please include the actual, raw output from ESLint.

0 errors in the first example:

/* eslint new-parens:["error", "always"] */

// false negative, the outer `new` does not have parens.
new new foo();

2 errors and a bit invalid autofix in the second example:

/* eslint new-parens:["error", "never"] */

// false positive for the outer `new` and invalid autofix - wrong place for parens
(new new foo);

What changes did you make? (Give an overview)

Check that the parens are not a part of the child node.

Is there anything you'd like reviewers to focus on?

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Sep 23, 2019
@platinumazure platinumazure added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Sep 29, 2019
Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@mysticatea mysticatea merged commit 41bfe91 into master Sep 29, 2019
@mysticatea mysticatea deleted the newparens-chained branch September 29, 2019 03:38
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Mar 29, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants