Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: improve report location for no-multi-spaces #12329

Merged
merged 1 commit into from Oct 17, 2019
Merged

Update: improve report location for no-multi-spaces #12329

merged 1 commit into from Oct 17, 2019

Conversation

golopot
Copy link
Contributor

@golopot golopot commented Sep 28, 2019 •
edited

What is the purpose of this pull request? (put an "X" next to item)

[x] Changes an existing rule

What changes did you make? (Give an overview)

Change the report location of no-multi-spaces. Previously the rule highlights the token next to the problematic spaces. Now the rule highlights the problematic spaces.

foo &&  moo
//      ~~~    before
//    ~~       after

[1, 2,   ...a]
//       ~~~   before
//    ~~~      after

Is there anything you'd like reviewers to focus on?
no

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Sep 28, 2019
@g-plane g-plane added enhancement This change enhances an existing feature of ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Sep 28, 2019
g-plane
g-plane approved these changes Sep 28, 2019
View reviewed changes
Copy link
Member

@g-plane g-plane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

kaicataldo
kaicataldo approved these changes Sep 28, 2019
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

mdjermanovic
mdjermanovic approved these changes Sep 28, 2019
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks, I tried this in VS Code and it looks much better now!

@mdjermanovic mdjermanovic self-assigned this Oct 17, 2019
@mdjermanovic
Copy link
Member

This needs one more 👍 to be accepted.

@platinumazure platinumazure added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Oct 17, 2019
platinumazure
platinumazure approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for contributing!

@platinumazure
Copy link
Member

This is now accepted!

@platinumazure platinumazure merged commit d61c8a5 into eslint:master Oct 17, 2019
@platinumazure
Copy link
Member

I've gone ahead and merged this. Thanks @golopot for contributing!

This was referenced Nov 9, 2019
Open
Open
@snyk-bot snyk-bot mentioned this pull request Nov 21, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Dec 1, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 13, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 27, 2020
Merged
@golopot golopot deleted the location-no-multi-spaces branch March 1, 2020 15:50
@a-martynovich a-martynovich mentioned this pull request Mar 10, 2020
Merged
This was referenced Mar 11, 2020
Merged
Open
This was referenced Mar 26, 2020
Merged
Merged
Merged
This was referenced Apr 1, 2020
Open
Merged
Merged
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 16, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@platinumazure platinumazure platinumazure approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

@g-plane g-plane g-plane approved these changes

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees

@mdjermanovic mdjermanovic

Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@golopot @mdjermanovic @platinumazure @kaicataldo @g-plane