Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix typo in no-magic-numbers #12345

Merged
merged 1 commit into from Oct 1, 2019
Merged

Conversation

JosiahRooney
Copy link
Contributor

@JosiahRooney JosiahRooney commented Sep 30, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ x ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Added a missing "s" to "times" to correct the grammar.

Is there anything you'd like reviewers to focus on?

@jsf-clabot
Copy link

jsf-clabot commented Sep 30, 2019

CLA assistant check
All committers have signed the CLA.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Sep 30, 2019
@JosiahRooney JosiahRooney changed the title Fix typo Fix: Typo Sep 30, 2019
@JosiahRooney JosiahRooney changed the title Fix: Typo Chore: Typo Sep 30, 2019
@captchadex
Copy link

Nice

Copy link
Member

@g-plane g-plane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kaicataldo kaicataldo changed the title Chore: Typo Docs: fix typo in no-magic-numbers Sep 30, 2019
@kaicataldo kaicataldo added accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation and removed triage An ESLint team member will look at this issue soon labels Sep 30, 2019
@kaicataldo
Copy link
Member

@JosiahRooney Do you mind changing the commit message to match the PR title so that our CI check passes? This is important because we automate releases and the creation of changelogs using this format. Thank you for contributing!

@JosiahRooney
Copy link
Contributor Author

@kaicataldo I've amended the commit message to match. Thanks!

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Mar 31, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants