Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing word in sentence #12361

Merged
merged 1 commit into from Oct 3, 2019
Merged

Fix missing word in sentence #12361

merged 1 commit into from Oct 3, 2019

Conversation

dboulet
Copy link
Contributor

@dboulet dboulet commented Oct 2, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Very minor change to the documentation.

Is there anything you'd like reviewers to focus on?
No.

@jsf-clabot
Copy link

jsf-clabot commented Oct 2, 2019

CLA assistant check
All committers have signed the CLA.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Oct 2, 2019
@kaicataldo
Copy link
Member

kaicataldo commented Oct 2, 2019

Thanks for contributing to ESLint! Do you mind updating the commit message to the format we request in the commit-message check? Doing so helps us automate our release and change log creation process.

@kaicataldo kaicataldo added accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation and removed triage An ESLint team member will look at this issue soon labels Oct 2, 2019
@dboulet
Copy link
Contributor Author

dboulet commented Oct 3, 2019

Thanks, @kaicataldo. I’ve amended my commit message and all checks are now passing.

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for contributing!

@platinumazure platinumazure merged commit c47fa0d into eslint:master Oct 3, 2019
@dboulet dboulet deleted the patch-1 branch October 3, 2019 20:06
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 2, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants